Re: [Qemu-devel] [PATCH 00/23] bsd-user: FreeBSD support for mips/mips64 and arm

[Peter Maydell]

On 24 June 2013 03:03, Stacey Son <address@hidden> wrote:
> This patch series add BSD user mode support for FreeBSD.  In addition,
> it adds the necessary architecture dependent code for the mips, mips64,
> and arm targets.  In its current state it can emulate most mips/mips64
> and arm target binaries on a x86 host in a simple chroot environment
> (see https://wiki.freebsd.org/QemuUserModeHowTo for example).

> Besides adding a lot of shims and other support code this change
> restructures the code significantly to reduce the amount of C
> preprocessor conditionals for the various target and host arch/OS's.
> In general, the target cpu depedent code has been moved into into
> the various arch directories and the host OS dependent code (ie.
> FreeBSD, NetBSD, OpenBSD) has been moved into the OS directories as
> much as possible.

>  178 files changed, 23181 insertions(+), 2192 deletions(-)

This is an awful lot of code to ask people to review.
Your patchset here is doing a lot of things:
 * restructuring to put cpu dependent code into subdirs
 * adding ARM support
 * adding MIPS support
 * adding support for lots of extra system calls
and it's also doing them all jumbled up together, and includes
individual patches which do more than one thing at once.

I'm not the bsd-user maintainer, but my suggestion would be
that you'll find it much easier to get your code submitted if
you try to get these various new features added one at a time
rather than all at once.

PS: for future bsd-user patch submissions you should cc
Blue Swirl <address@hidden> who is the bsd-user maintainer
(see the MAINTAINERS file).

thanks
-- PMM