Re: [Qemu-devel] [PATCH 3/3] target-arm: explicitly decode SEVL instruction

[Andreas Färber]

Am 07.06.2013 14:06, schrieb Mans Rullgard:
> The ARMv8 SEVL instruction is in the architectural hint space already
> emulated as nop.  This makes the decoding of SEVL explicit for clarity.
> 
> Signed-off-by: Mans Rullgard <address@hidden>
> ---
>  target-arm/translate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index f529257..cfd148e 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -3501,6 +3501,7 @@ static void gen_nop_hint(DisasContext *s, int val)
>          break;
>      case 2: /* wfe */
>      case 4: /* sev */
> +    case 5: /* sevl */
>          /* TODO: Implement SEV and WFE.  May help SMP performance.  */
>      default: /* nop */
>          break;

So does SEVL need to be implemented? Then the TODO should be updated.
Otherwise moving it a line down may be clearer.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg