Re: [Qemu-devel] [PATCH 1/3] target-arm: add feature flag for ARMv8

[Peter Maydell]

On 7 June 2013 13:06, Mans Rullgard <address@hidden> wrote:
> Signed-off-by: Mans Rullgard <address@hidden>
> ---
>  target-arm/cpu.c       | 5 ++++-
>  target-arm/cpu.h       | 1 +
>  target-arm/translate.c | 1 +
>  3 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/target-arm/cpu.c b/target-arm/cpu.c
> index 496a59f..f5a1314 100644
> --- a/target-arm/cpu.c
> +++ b/target-arm/cpu.c
> @@ -162,6 +162,9 @@ static void arm_cpu_realizefn(DeviceState *dev, Error 
> **errp)
>      CPUARMState *env = &cpu->env;
>
>      /* Some features automatically imply others: */
> +    if (arm_feature(env, ARM_FEATURE_V8)) {
> +        set_feature(env, ARM_FEATURE_V7);
> +    }

This should also imply ARM_FEATURE_ARM_DIV and ARM_FEATURE_LPAE.

thanks
-- PMM