[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/9] block: bdrv_reopen_prepare(): don't use QER
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 8/9] block: bdrv_reopen_prepare(): don't use QERR_OPEN_FILE_FAILED |
Date: |
Tue, 11 Jun 2013 08:32:32 -0400 |
On Tue, 11 Jun 2013 10:38:47 +0200
Kevin Wolf <address@hidden> wrote:
> Am 10.06.2013 um 19:02 hat Luiz Capitulino geschrieben:
> > The call to drv->bdrv_reopen_prepare() can fail due to reasons
> > other than an open failure. Unfortunately, we can't use errno
> > nor -ret, cause they are not always set.
> >
> > Stick to a generic error message then.
> >
> > Signed-off-by: Luiz Capitulino <address@hidden>
> > ---
> > block.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/block.c b/block.c
> > index 79ad33d..b88ad2f 100644
> > --- a/block.c
> > +++ b/block.c
> > @@ -1291,8 +1291,8 @@ int bdrv_reopen_prepare(BDRVReopenState
> > *reopen_state, BlockReopenQueue *queue,
> > if (local_err != NULL) {
> > error_propagate(errp, local_err);
> > } else {
> > - error_set(errp, QERR_OPEN_FILE_FAILED,
> > - reopen_state->bs->filename);
> > + error_setg(errp, "failed while preparing to reopen image
> > '%s'",
>
> Please start the message with an uppercase letter like before.
Fixed.
> Also, maybe "Failed to prepare for reopening '%s'" is better?
I have no idea :)
- [Qemu-devel] [PATCH v2 0/9] QMP/HMP: add error reason to open failures, Luiz Capitulino, 2013/06/10
- [Qemu-devel] [PATCH 4/9] blockdev: use error_setg_file_open(), Luiz Capitulino, 2013/06/10
- [Qemu-devel] [PATCH 5/9] cpus: use error_setg_file_open(), Luiz Capitulino, 2013/06/10
- [Qemu-devel] [PATCH 2/9] rng-random: use error_setg_file_open(), Luiz Capitulino, 2013/06/10
- [Qemu-devel] [PATCH 1/9] error: add error_setg_file_open() helper, Luiz Capitulino, 2013/06/10
- [Qemu-devel] [PATCH 3/9] block: mirror_complete(): use error_setg_file_open(), Luiz Capitulino, 2013/06/10
- [Qemu-devel] [PATCH 7/9] savevm: qmp_xen_save_devices_state(): use error_setg_file_open(), Luiz Capitulino, 2013/06/10
- [Qemu-devel] [PATCH 9/9] qerror: drop QERR_OPEN_FILE_FAILED macro, Luiz Capitulino, 2013/06/10
- [Qemu-devel] [PATCH 8/9] block: bdrv_reopen_prepare(): don't use QERR_OPEN_FILE_FAILED, Luiz Capitulino, 2013/06/10
- [Qemu-devel] [PATCH 6/9] dump: qmp_dump_guest_memory(): use error_setg_file_open(), Luiz Capitulino, 2013/06/10
- Re: [Qemu-devel] [PATCH v2 0/9] QMP/HMP: add error reason to open failures, Stefan Hajnoczi, 2013/06/11
- Re: [Qemu-devel] [PATCH v2 0/9] QMP/HMP: add error reason to open failures, Stefan Hajnoczi, 2013/06/11
- Re: [Qemu-devel] [PATCH v2 0/9] QMP/HMP: add error reason to open failures, Kevin Wolf, 2013/06/11