[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 0/9] QMP/HMP: add error reason to open failur

From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v2 0/9] QMP/HMP: add error reason to open failures
Date: Tue, 11 Jun 2013 10:40:17 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 10.06.2013 um 19:02 hat Luiz Capitulino geschrieben:
> I was surprised to find out that we still have old users of
> QERR_OPEN_FILE_FAILED that print errors like:
> (qemu) dump-guest-memory -p /lkmads/foo
> Could not open '/lkmads/foo'
> (qemu)
> This series converts all those users to a new helper called
> error_setg_file_open(), which adds error reason to open failures:
> (qemu) dump-guest-memory -p /sfmdkjf/foo
> Could not open '/sfmdkjf/foo': No such file or directory
> (qemu) 
> v2
>  - bdrv_reopen_prepare(): use generic error message
>  - s/error/-ret for bdrv_open() errors

I suggested an error message change in patch 8, but I think that's minor
enough that you don't have to resend the series after changing the text.
So you can add:

Acked-by: Kevin Wolf <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]