[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building aft
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge |
Date: |
Tue, 09 Apr 2013 13:48:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 09/04/2013 13:30, Markus Armbruster ha scritto:
>>> >> We have two virtio-9p.h:
>>> >> ./hw/9pfs/virtio-9p.h
>>> >> ./include/hw/virtio/virtio-9p.h
>>> >>
>>> >> which can be confusing.
>> >
>> > Yes, the first one is only included with a local path. Though I think
>> > this is what confused my scripts.
> It'll confuse maintenance programmers, too. Rename one of them? For
> what it's worth, the second was named virtio-9p-device.h until you
> renamed & moved it.
The second isn't named virtio-9p.h. It is named hw/virtio/virtio-9p.h.
There is no -Iinclude/hw/virtio path, so you need the full path to
include it.
If you look at Linux, you have similarly include/scsi/scsi.h (for
#include <scsi/scsi.h>) and drivers/scsi/scsi.h (for #include "scsi.h").
Paolo
Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge, Anthony Liguori, 2013/04/15