Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge

[KONRAD Frédéric]

On 09/04/2013 10:36, Paolo Bonzini wrote:
> Il 09/04/2013 10:22, Hans de Goede ha scritto:
> > Signed-off-by: Hans de Goede <address@hidden>
> > Cc: Paolo Bonzini <address@hidden>
> > ---
> >   hw/9pfs/virtio-9p-device.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> Ouch, /me installs libcap-ng-devel.
>
> Thanks.
>
> Paolo
>
> > diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
> > index 43f930e..b476b81 100644
> > --- a/hw/9pfs/virtio-9p-device.c
> > +++ b/hw/9pfs/virtio-9p-device.c
> > @@ -12,11 +12,11 @@
> >    */
> >   
> >   #include "hw/virtio/virtio.h"
> > +#include "hw/virtio/virtio-9p.h"
[..]
> >   #include "virtio-9p.h"
Is that normal?

We have two virtio-9p.h:
./hw/9pfs/virtio-9p.h
./include/hw/virtio/virtio-9p.h

which can be confusing.

is it not better to re-rename virtio-9p.h => virtio-9p-device.h?
> > -#include "virtio-9p-device.h"
> >