[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring.
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring. |
Date: |
Mon, 8 Apr 2013 18:03:49 +0100 |
On 8 April 2013 18:00, KONRAD Frédéric <address@hidden> wrote:
> I'm making a patch for that, and I'm wondering if the name in
> register_savevm must be changed too?
>
> eg for virtio-balloon:
>
> - register_savevm(qdev, "virtio-balloon", -1, 1,
> + register_savevm(qdev, TYPE_VIRTIO_BALLOON, -1, 1,
> virtio_balloon_save, virtio_balloon_load, s);
>
> with TYPE_VIRTIO_BALLOON "virtio-balloon-device"?
You specifically don't want to change the register_savevm name,
because otherwise you'll break migration (we use the ID string
to identify what incoming migration data is).
-- PMM
- [Qemu-devel] [PATCH v5 1/7] virtio-serial: add the virtio-serial device., (continued)
- [Qemu-devel] [PATCH v5 1/7] virtio-serial: add the virtio-serial device., fred . konrad, 2013/04/04
- [Qemu-devel] [PATCH v5 4/7] virtio-serial-ccw: switch to the new API., fred . konrad, 2013/04/04
- [Qemu-devel] [PATCH v5 3/7] virtio-serial-s390: switch to the new API., fred . konrad, 2013/04/04
- [Qemu-devel] [PATCH v5 6/7] virtio-serial: cleanup: use QOM casts., fred . konrad, 2013/04/04
- [Qemu-devel] [PATCH v5 5/7] virtio-serial: cleanup: init and exit functions., fred . konrad, 2013/04/04
- [Qemu-devel] [PATCH v5 7/7] virtio-serial: cleanup: remove qdev field., fred . konrad, 2013/04/04
- Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring., Cornelia Huck, 2013/04/04
- Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring., Peter Maydell, 2013/04/04
- Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring., Anthony Liguori, 2013/04/05