Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring.

[Anthony Liguori]

address@hidden writes:

> From: KONRAD Frederic <address@hidden>
>
> This is the next part of virtio-refactoring.
>
> Basically it creates virtio-serial device which extends virtio-device.
> Then a virtio-serial can be connected on a virtio-bus.
> virtio-serial-pci, virtio-serial-s390 and virtio-serial-ccw are created too,
> they extend respectively virtio-pci, virtio-s390-device, virtio-ccw-device and
> have a virtio-serial.
>
> You can checkout my branch here:
>
> git://project.greensocs.com/qemu-virtio.git virtio-serial-v5
>
> Note that it is nearly the same series as virtio-blk and virtio-scsi
> refactoring.

/home/aliguori/build/qemu/x86_64-softmmu/qemu-system-x86_64 -kernel 
/usr/local/share/qemu-jeos/kernel-x86_64-pc -initrd 
.tmp-11584/initramfs-11584.img.gz -device isa-debug-exit -append console=ttyS0 
seed=42872 -nographic -enable-kvm -hda .tmp-11584/disk-11584.img -M pc-0.13 
-drive file=.tmp-11584/disk-11584.img,if=virtio,snapshot=on -device 
virtio-balloon-pci -device virtio-serial -net nic,model=virtio -net user 
-pidfile .tmp-11584/pidfile-11584.pid -qmp 
unix:.tmp-11584/qmpsock-11584.sock,server,nowait
qemu-system-x86_64: -device virtio-serial: No 'virtio-bus' bus found for
device 'virtio-serial'

I think we need to go back and name the devices 'virtio-serial-device'
et al to avoid breaking aliases.

Regards,

Anthony Liguori

>
> I made basic tests (with linux guests) on:
>  * qemu-system-i386
>
> Changes v4 -> v5:
>     * Fixed rebase issue with nvector and the clarifying comment.
>     * Changed property macro for s390 and ccw device too.
>
> Changes v3 -> v4:
>     * Removed serial configuration field ommited in VirtioCCWDevice structure.
>
> Changes v2 -> v3:
>     * Added CCW device.
>     * Rebased.
>
> Thanks,
>
> Fred
>
> KONRAD Frederic (7):
>   virtio-serial: add the virtio-serial device.
>   virtio-serial-pci: switch to the new API.
>   virtio-serial-s390: switch to the new API.
>   virtio-serial-ccw: switch to the new API.
>   virtio-serial: cleanup: init and exit functions.
>   virtio-serial: cleanup: use QOM casts.
>   virtio-serial: cleanup: remove qdev field.
>
>  hw/s390x/s390-virtio-bus.c |  31 +++++----
>  hw/s390x/s390-virtio-bus.h |  12 +++-
>  hw/s390x/virtio-ccw.c      |  29 +++++----
>  hw/s390x/virtio-ccw.h      |  12 +++-
>  hw/virtio-pci.c            | 131 +++++++++++++++++++------------------
>  hw/virtio-pci.h            |  14 +++-
>  hw/virtio-serial-bus.c     | 157 
> +++++++++++++++++++++++++++------------------
>  hw/virtio-serial.h         |  13 +++-
>  8 files changed, 239 insertions(+), 160 deletions(-)
>
> -- 
> 1.7.11.7