Re: [Qemu-devel] Build failure with -werror on i386

[Jesse Larrew]

Hi David!

On 02/21/2013 05:19 PM, David Holsgrove wrote:
> Configuring QEMU as
> 
> ./configure --target-list=i386-softmmu --cpu=i386 --enable-werror
> 
> results in following error
> 
> cc1: warnings being treated as errors
> qemu-char.c: In function 'qmp_ringbuf_write':
> qemu-char.c:2764: error: passing argument 2 of 'g_base64_decode' from 
> incompatible pointer type
> /usr/include/glib-2.0/glib/gbase64.h:49: note: expected 'gsize *' but 
> argument is of type 'size_t *'
> 
> A git-blame (not a bisect) seems to indicate this was introduced with the 
> following commit.
> 
> commit 1f590cf9455c571799d1bfc0777255fa0796d4da
> Author: Lei Li <address@hidden>
> Date:   Fri Jan 25 00:03:20 2013 +0800
> 
>     QAPI: Introduce memchar-write QMP command
> 
>     Signed-off-by: Lei Li <address@hidden>
>     Signed-off-by: Luiz Capitulino <address@hidden>

Looking at the commit, Lei Li's patch does correctly cast the size_t* to
gsize* in qmp_ringbuf_write(). It also builds correctly on my system
(Fedora 17 on x86_64) using -Werror.

Are you using a separate build directory for qemu, or are you building
in-tree? In-tree builds can be flaky sometimes, because 'make distclean'
can leave some stale bits lying around...

Maybe this is the issue?

> 
> This was produced on an Ubuntu 10.04 x86_64 machine.
> 
> regards,
> David
> 

Sincerely,

Jesse Larrew
Software Engineer, KVM Team
IBM Linux Technology Center
Phone: (512) 973-2052 (T/L: 363-2052)
address@hidden