Re: [Qemu-devel] [PATCH V25 6/7] Add support for cancelling of a TPM command

[Stefan Berger]

On 02/26/2013 05:04 PM, Corey Bryant wrote:
> On 02/21/2013 11:33 AM, Stefan Berger wrote:
> > address@hidden -tpmdev passthrough, address@hidden, address@hidden
> > address@hidden -tpmdev passthrough, address@hidden, address@hidden, 
> > address@hidden
>
> The last path= should be cancel-path=

Fixed

> >           goto err_exit;
> >       }
> >
> > +    tb->s.tpm_pt->cancel_fd = tpm_passthrough_open_sysfs_cancel(tb);
> > +
> @@ -337,6 +471,8 @@ static TPMBackend *tpm_passthrough_create(QemuOpts 
> *opts, const char *id)
>
> I think this needs a failure path if cancel_fd == -1.  I'm able to 
> start a guest with:
>
> -tpmdev passthrough,id=tpm0,path=/dev/tpm0,cancel-path=/dev/junk

Fixed.