Re: [Qemu-devel] [PATCH v2 8/8] qtest: Add boot order test

[Andreas Färber]

Am 22.02.2013 18:20, schrieb Markus Armbruster:
> diff --git a/tests/boot-order-test.c b/tests/boot-order-test.c
> new file mode 100644
> index 0000000..60412ad
> --- /dev/null
> +++ b/tests/boot-order-test.c
[...]
> +static void test_pc_with_args(const char *args, uint8_t boot1, uint8_t boot2,
> +                              uint8_t reboot1, uint8_t reboot2)
> +{
> +    char *extra_args = g_strdup_printf("-nodefaults -display none -S %s",
> +                                       args);

Why do you add -S here? qtest is an accel mode of its own and should
never execute anything.

Also in my code I found it more logical to add extra args to args rather
than the reverse, not just because of 80 chars limit when trying to add
-machine argument. ;)

I assume q35 is reusing pc code? Or should it be tested as well?
(Having any of our qtests cover it would be nice.)

> +    qtest_start(extra_args);
> +    test_cmos(boot1, boot2);

> +    qtest_qmp(global_qtest, "{ 'execute': 'system_reset' }");

qmp()?

> +    test_cmos(reboot1, reboot2);
> +    qtest_quit(global_qtest);
> +    g_free(extra_args);
> +}
[snip]

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg