[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 8/8] qtest: Add boot order test
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 8/8] qtest: Add boot order test |
Date: |
Fri, 22 Feb 2013 19:09:58 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Andreas Färber <address@hidden> writes:
> Am 22.02.2013 18:20, schrieb Markus Armbruster:
>> Covers only PC so far.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> Reviewed-by: Andreas Färber <address@hidden>
>
>> +static void test_cmos_byte(int reg, int expected)
>> +{
>> + int actual;
>> +
>> + outb(0x70 + 0, reg);
>> + actual = inb(0x71);
>
> Did you intend to use 0x70 + 1 here or why the 0x70 + 0 above?
Looks like a pasto to me. Let's drop the stupid '+ 0'.
>> + g_assert_cmphex(actual, ==, expected);
>> +}
>
>> +int main(int argc, char *argv[])
>> +{
>> + g_test_init(&argc, &argv, NULL);
>> +
>> + qtest_add_func("boot-order/pc", test_pc_boot_order);
>> +
>> + return g_test_run();
>> +}
>
> So this is suggesting to me to add separate test functions per arch.
> Fine with me, we'll only have to reindent one line then.
>
> Thanks for the changes,
Hard to predict for me how the tests for other archs will look, and what
could be shared. Add them and see :)
- [Qemu-devel] [PATCH v2 1/8] vl: Clean up parsing of -boot option argument, (continued)
- [Qemu-devel] [PATCH v2 1/8] vl: Clean up parsing of -boot option argument, Markus Armbruster, 2013/02/22
- [Qemu-devel] [PATCH v2 3/8] vl: Fix -boot order and once regressions, and related bugs, Markus Armbruster, 2013/02/22
- [Qemu-devel] [PATCH v2 2/8] qemu-option: check_params() is now unused, drop it, Markus Armbruster, 2013/02/22
- [Qemu-devel] [PATCH v2 5/8] pc: Make -no-fd-bootchk stick across boot order changes, Markus Armbruster, 2013/02/22
- [Qemu-devel] [PATCH v2 6/8] pc: Drop ref to Bochs from -no-fd-bootchk documentation, Markus Armbruster, 2013/02/22
- [Qemu-devel] [PATCH v2 4/8] vl: Rename *boot_devices to *boot_order, for consistency, Markus Armbruster, 2013/02/22
- [Qemu-devel] [PATCH v2 7/8] qtest: Don't reset on qtest chardev connect, Markus Armbruster, 2013/02/22
- [Qemu-devel] [PATCH v2 8/8] qtest: Add boot order test, Markus Armbruster, 2013/02/22