Re: [Qemu-devel] [RFC V2 12/16] qapi: Add support for deduplication infos in qapi-schema.json.

[Eric Blake]

On 02/06/2013 05:32 AM, Benoît Canet wrote:
> ---
>  qapi-schema.json |   40 +++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 39 insertions(+), 1 deletion(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index cf4e9d6..ec61f6a 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -814,6 +814,40 @@
>                                     'stopping' ] }
>  
>  ##
> +# @BlockDeviceDedupInfo
> +#
> +# Statistics of the deduplication on a virtual block device implementing it
> +# since QEMU startup.

Ambiguous - is it the block implementing dedup since qemu startup, or
statistics collected since qemu startup?  I think it is fine to shorten
to just:

Statistics about block device deduplication.

> +#
> +# @deduplicated-clusters:     Number of clusters which where deduplicated.
> +#
> +# @non-deduplicated-clusters: Number of clusters which where not 
> deduplicated.

That's long; would it be any better calling it:

@unique-clusters: Number of clusters found to be unique.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature