[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V2 11/16] qcow2: Count deduplication refcount over
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC V2 11/16] qcow2: Count deduplication refcount overflow metric. |
Date: |
Thu, 07 Feb 2013 08:37:17 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 02/06/2013 05:32 AM, Benoît Canet wrote:
> ---
> block/qcow2-dedup.c | 1 +
> 1 file changed, 1 insertion(+)
It wouldn't hurt to squash several of these one-liner patches into a
bigger patch that turns on collection of all stats in one go.
>
> diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
> index e159e77..308b4f6 100644
> --- a/block/qcow2-dedup.c
> +++ b/block/qcow2-dedup.c
> @@ -1024,6 +1024,7 @@ void
> qcow2_dedup_refcount_half_max_reached(BlockDriverState *bs,
>
> /* remove the QCowHashNode from ram so we won't use it anymore for dedup
> */
> qcow2_remove_hash_node(bs, hash_node);
> + s->dedup_metrics.refcount_overflows++;
> }
>
> bool qcow2_dedup_is_running(BlockDriverState *bs)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC V2 00/16] QCOW2 deduplication metrics, Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 01/16] qcow2: Add qcow2_co_dedup_resume to restart deduplication., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 03/16] qcow2: Add deduplication metrics structures., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 05/16] qcow2: Collect unaligned writes missing data reads metric., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 06/16] qcow2: Collect deduplicated cluster metric., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 14/16] qcow2: Add qcow2_dedup_update_metrics to compute dedup RAM usage., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 15/16] qcow2: returns deduplication metrics and status via bdrv_get_info(), Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 10/16] qcow2: Count cluster deleted metric, Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 11/16] qcow2: Count deduplication refcount overflow metric., Benoît Canet, 2013/02/06
- Re: [Qemu-devel] [RFC V2 11/16] qcow2: Count deduplication refcount overflow metric.,
Eric Blake <=
- [Qemu-devel] [RFC V2 07/16] qcow2: Collect undeduplicated cluster metric., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 02/16] qcow2: Enable the deduplication feature., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 04/16] qcow2: Initialize deduplication metrics., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 08/16] qcow2: Count QCowHashNode creation metrics., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 09/16] qcow2: Count QCowHashNode removal from tree for metrics., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 16/16] qapi: Return virtual block device deduplication metrics in QMP, Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 12/16] qapi: Add support for deduplication infos in qapi-schema.json., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V2 13/16] block: Add deduplication metrics to BlockDriverInfo., Benoît Canet, 2013/02/06