[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler |
Date: |
Mon, 17 Dec 2012 18:21:51 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
Am 17.12.2012 15:49, schrieb Alexander Graf:
>
> On 14.12.2012, at 17:46, Jens Freimann wrote:
>
>> @@ -37,12 +42,30 @@ static void s390_cpu_reset(CPUState *s)
>> log_cpu_state(env, 0);
>> }
>>
>> - scc->parent_reset(s);
>> + s390_del_running_cpu(env);
>>
>> + scc->parent_reset(s);
>> memset(env, 0, offsetof(CPUS390XState, breakpoints));
>
> Shouldn't parent_reset already do the memset?
No, because "env" location and size are specific to S390CPU.
And yes, it is ugly boilerplate code, but it cannot be solved with my
CPU_COMMON field movements alone (which partially add explicit reset
code based on the field location), there's quite a large number of
per-target fields that get reset that way, some intentionally, some
accidentally. ;-)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions, (continued)
[Qemu-devel] [PATCH 0/3] s390: ipl device, cpu reset handler and cpu model support, Jens Freimann, 2012/12/14
[Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions, Jens Freimann, 2012/12/14
[Qemu-devel] [PATCH 1/3] s390: Move IPL code into a separate device, Jens Freimann, 2012/12/14
[Qemu-devel] [PATCH 0/3] s390: ipl device, cpu reset handler and cpu model support, Jens Freimann, 2012/12/18