qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-de


From: Viktor Mihajlovski
Subject: Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions
Date: Wed, 12 Dec 2012 16:05:20 +0100
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0

On 12/12/2012 02:51 PM, Andreas Färber wrote:
+    (*cpu_fprintf)(f, "s390 %16s\n", "[host]");

Note that the square-bracket notation was specific to x86 when it
distinguished between built-in and config-based models.

OK, since libvirt capable of dealing with s390 cpu models will
never see this, we can change it any way that is wanted.
So, host without brackets?
"host" only makes sense for KVM, not for TCG. So we would need one other
placeholder model for libvirt.
see my reply to Alex' comment: the placeholder name must be chosen
carefully, i.e. future-proof

--

Mit freundlichen Grüßen/Kind Regards
   Viktor Mihajlovski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294




reply via email to

[Prev in Thread] Current Thread [Next in Thread]