[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk. |
Date: |
Thu, 6 Dec 2012 14:21:16 +0000 |
On 6 December 2012 13:58, KONRAD Frédéric <address@hidden> wrote:
> On 06/12/2012 11:13, Peter Maydell wrote:
>> It can't just be a command line alias, or we will break migration.
>> It has to be a simple device that composes together the virtio-pci
>> and virtio-blk devices, plus legacy support for properties and
>> migration state, I think.
> Can we do virtio-blk refactoring and virtio-blk-pci at the same time for not
> breaking anything ?
Not breaking things is a key part of the requirements here.
It's ok to say "I haven't converted virtio-net or the s390
transport in this patchset and therefore they are broken" as
an initial RFC (because we can look at how PCI/blk is done
and check it works before we expand the same thing out to
other transports/devices). But you need to show how the
virtio-blk / virtio-pci refactoring works and leaves you with
a virtio-blk-pci that isn't broken (either at the end or at
any step along the way).
-- PMM
- Re: [Qemu-devel] [RFC PATCH v5 5/6] virtio-device : Refactor virtio-device., (continued)
- [Qemu-devel] [RFC PATCH v5 3/6] virtio-pci-bus : Introduce virtio-pci-bus., fred . konrad, 2012/12/04
- [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., fred . konrad, 2012/12/04
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., Peter Maydell, 2012/12/05
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., Andreas Färber, 2012/12/05
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., KONRAD Frédéric, 2012/12/06
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., Andreas Färber, 2012/12/06
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., KONRAD Frédéric, 2012/12/06
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., Peter Maydell, 2012/12/06
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., KONRAD Frédéric, 2012/12/06
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.,
Peter Maydell <=
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., KONRAD Frédéric, 2012/12/06
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., KONRAD Frédéric, 2012/12/06
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., Andreas Färber, 2012/12/06
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., KONRAD Frédéric, 2012/12/06