Am 06.12.2012 10:11, schrieb KONRAD Frédéric:
On 05/12/2012 17:25, Peter Maydell wrote:
On 4 December 2012 14:35, <address@hidden> wrote:
-static VirtIOBlock *to_virtio_blk(VirtIODevice *vdev)
-{
- return (VirtIOBlock *)vdev;
-}
+/*
+ * Use the QOM cast, so we don't need that anymore.
+ *
+ * static VirtIOBlock *to_virtio_blk(VirtIODevice *vdev)
+ * {
+ * return (VirtIOBlock *)vdev;
+ * }
+ */
If we don't need it, just delete it.
-- PMM
Yes, sure, I put it in comment to explain, why I deleted it.
Please don't comment out unneeded things. Instead, remove them
completely and put the explanation into the commit message. That helps
keep the patch small and avoids commented-out code bitrotting.
Andreas