Re: [Qemu-devel] [PULL 00/18] acpi: switch to memory api

[Gerd Hoffmann]

On 12/04/12 16:57, Andreas Färber wrote:
> Hi Gerd,
> 
> Am 04.12.2012 14:04, schrieb Gerd Hoffmann:
>>   Hi,
>>
>> Same patches as posted last week.  No review comments, 1.4 tree
>> open, so it should be ready to go in now.
> 
> That's not quite true - you ignored my review comment wrt MemoryRegion
> placement (and I left it to you to look for further instances). Can you
> please fix that up on your branch or as follow-up?

You mean that empty line after parent_object?  I can send a followup for
that one.

Why it is important btw?  Just style?  Some parser tool?  Can we make
checkpatch.pl check this?

> Did you see any overlap with Julien's series or can I post my PULL in
> parallel?

Given that you kicked out the acpi changes due to q35 merge conflicts it
should work in parallel as my series touches acpi only.  Havn't actually
tried to merge though.

A small followup is needed once both are in: replace get_system_io()
with the new isa_address_space() in the acpi code.

cheers,
  Gerd