[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/12] qdev: separate core from the code used on
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 03/12] qdev: separate core from the code used only by qemu-system-* |
Date: |
Fri, 19 Oct 2012 09:31:00 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Eduardo Habkost <address@hidden> writes:
> On Wed, Oct 17, 2012 at 01:00:55PM -0500, Anthony Liguori wrote:
[...]
>> I don't really understand the split here and the 'system' suffix really
>> doesn't explain it for me. Could you at least add a comment to each of
>> these files explaining what belongs in them?
>
> "system" here means "Code used only by qemu-system-*" (in other words,
> not used by *-user, and not part of the qdev core). Do you have other
> name suggestions?
>
> The goal here is to make qdev-core.c/qdev-properties as small as
> possible (only what's absolutely required for the CPU classes), and put
> everything else (that's only used by qemu-system-*) into
> qdev-system.c/qdev-properties-system.c.
Creates a permanent if minor development burden: where should my
property code go?
Doubt it's worth the trouble:
text data bss dec hex filename
15897 1448 0 17345 43c1 bld/hw/qdev-properties.o
In theory, link-time optimizations can drop unused code. Not sure they
do in practice.
[Qemu-devel] [PATCH 05/12] qdev-core: isolate vmstate handling into separate functions, Igor Mammedov, 2012/10/15
[Qemu-devel] [PATCH 06/12] qdev: move vmstate handling to qdev-system.c, Igor Mammedov, 2012/10/15
[Qemu-devel] [PATCH 04/12] qdev: rename qdev.c to qdev-core.c, Igor Mammedov, 2012/10/15
[Qemu-devel] [PATCH 07/12] qdev-core: isolate reset register/unregister code, Igor Mammedov, 2012/10/15
[Qemu-devel] [PATCH 09/12] move qemu_irq typedef out of cpu-common.h, Igor Mammedov, 2012/10/15
[Qemu-devel] [PATCH 10/12] qdev: use full qdev.h include path on qdev*.c, Igor Mammedov, 2012/10/15
[Qemu-devel] [PATCH 08/12] qdev: move reset register/unregister code to qdev-system.c, Igor Mammedov, 2012/10/15
[Qemu-devel] [PATCH 12/12] qom: make CPU a child of DeviceState, Igor Mammedov, 2012/10/15
[Qemu-devel] [PATCH 11/12] include core qdev code into *-user, too, Igor Mammedov, 2012/10/15