[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/12] qdev: separate core from the code used on
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 03/12] qdev: separate core from the code used only by qemu-system-* |
Date: |
Tue, 16 Oct 2012 15:20:02 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Oct 16, 2012 at 03:57:15AM +0200, Igor Mammedov wrote:
[...]
> @@ -0,0 +1,68 @@
> +#include "qdev.h"
> +
> +void qdev_init_gpio_in(DeviceState *dev, qemu_irq_handler handler, int n)
> +{
> + assert(dev->num_gpio_in == 0);
> + dev->num_gpio_in = n;
> + dev->gpio_in = qemu_allocate_irqs(handler, dev, n);
> +}
> +
[...]
> -void qdev_init_gpio_in(DeviceState *dev, qemu_irq_handler handler, int n)
> -{
> - dev->gpio_in = qemu_extend_irqs(dev->gpio_in, dev->num_gpio_in, handler,
> - dev, n);
> - dev->num_gpio_in += n;
> -}
Oops. It looks like you rebased but kept the old code.
I will fix this in the next version.
--
Eduardo
[Qemu-devel] [PATCH 05/12] qdev-core: isolate vmstate handling into separate functions, Igor Mammedov, 2012/10/15
[Qemu-devel] [PATCH 06/12] qdev: move vmstate handling to qdev-system.c, Igor Mammedov, 2012/10/15
[Qemu-devel] [PATCH 04/12] qdev: rename qdev.c to qdev-core.c, Igor Mammedov, 2012/10/15
[Qemu-devel] [PATCH 07/12] qdev-core: isolate reset register/unregister code, Igor Mammedov, 2012/10/15
[Qemu-devel] [PATCH 09/12] move qemu_irq typedef out of cpu-common.h, Igor Mammedov, 2012/10/15
[Qemu-devel] [PATCH 10/12] qdev: use full qdev.h include path on qdev*.c, Igor Mammedov, 2012/10/15