[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM archi
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture |
|
Date: |
Thu, 18 Oct 2012 18:53:26 +0100 |
On 18 October 2012 18:41, Jan Kiszka <address@hidden> wrote:
> Minor: If you do
>
> function()
> {
> #ifdef CONFIG_KVM
> ...
> #endif
> }
>
>> +
>> qemu_irq *arm_pic_init_cpu(ARMCPU *cpu)
>> {
>> +#ifdef CONFIG_KVM
>> + if (kvm_enabled()) {
>> + return qemu_allocate_irqs(kvm_arm_pic_cpu_handler, cpu, 2);
>> + }
>> +#endif
>
> ...you can avoid the ifdef'ery here.
Good idea -- will do that in next version.
-- PMM
- Re: [Qemu-devel] [RFC v2 4/6] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC, (continued)