qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM archi


From: Peter Maydell
Subject: Re: [Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture
Date: Thu, 18 Oct 2012 13:37:14 +0100

On 13 October 2012 10:09, Blue Swirl <address@hidden> wrote:
> On Wed, Oct 10, 2012 at 3:07 PM, Peter Maydell <address@hidden> wrote:
>> +#include "hw/arm-misc.h"
>> +
>> +const KVMCapabilityInfo kvm_arch_required_capabilities[] = {
>
> 'static'. In fact, 'static' not used at all in this file, probably it
> could be used a lot more.

Actually this one can't be static -- it's defined here but used in
kvm-all.c. The same applies for most of the functions in this file.
I was able to add a 'static' to the regs[] array, but I couldn't
find anywhere else here where a 'static' was missing.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]