[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/13] tcg: don't explicitely save globals and t
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 10/13] tcg: don't explicitely save globals and temps |
Date: |
Thu, 27 Sep 2012 12:13:25 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 09/27/2012 10:15 AM, Aurelien Jarno wrote:
> @@ -1706,11 +1718,9 @@ static void tcg_reg_alloc_mov(TCGContext *s, const
> TCGOpDef *def,
> if (!ots->mem_allocated) {
> temp_allocate_frame(s, args[0]);
> }
> - if (ts->val_type == TEMP_VAL_REG) {
> - tcg_out_st(s, ots->type, ts->reg, ots->mem_reg, ots->mem_offset);
> - if (IS_DEAD_ARG(1)) {
> - temp_dead(s, args[1]);
> - }
> + tcg_out_st(s, ots->type, ts->reg, ots->mem_reg, ots->mem_offset);
> + if (IS_DEAD_ARG(1)) {
> + temp_dead(s, args[1]);
> }
> temp_dead(s, args[0]);
> } else if (ts->val_type == TEMP_VAL_CONST) {
Did this hunk belong to a different patch? It seems like it belongs
with the tcg_reg_alloc_mov rewrite.
If it actually depends on patches 7-8, then perhaps a reorder is better.
r~
- Re: [Qemu-devel] [PATCH 13/13] tcg: rework TCG ops flags, (continued)
[Qemu-devel] [PATCH 11/13] tcg: sync globals for pure helpers instead of saving them, Aurelien Jarno, 2012/09/27
[Qemu-devel] [PATCH 09/13] tcg: start with local temps in TEMP_VAL_MEM state, Aurelien Jarno, 2012/09/27
[Qemu-devel] [PATCH 10/13] tcg: don't explicitely save globals and temps, Aurelien Jarno, 2012/09/27
- Re: [Qemu-devel] [PATCH 10/13] tcg: don't explicitely save globals and temps,
Richard Henderson <=
[Qemu-devel] [PATCH 07/13] tcg: rewrite tcg_reg_alloc_mov(), Aurelien Jarno, 2012/09/27
[Qemu-devel] [PATCH 05/13] tcg: rework liveness analysis, Aurelien Jarno, 2012/09/27
[Qemu-devel] [PATCH 04/13] tcg: sync output arguments on liveness request, Aurelien Jarno, 2012/09/27