[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/13] tcg: sync globals for pure helpers instea
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 11/13] tcg: sync globals for pure helpers instead of saving them |
Date: |
Thu, 27 Sep 2012 15:02:42 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 09/27/2012 01:34 PM, Aurelien Jarno wrote:
>> (1) Helper may read globals. Sometimes indirectly via exception.
>> Implies that globals must be synced, but may remain in REG/CONST state.
>
> I actually do wonder if we shouldn't use a different flag for "may
> trigger exception", even if we end-up handling it the same way as "may
> read globals". I am not sure it would be clear without knowledge of the
> QEMU internals that a function triggering exceptions should be flagged
> as "read globals".
I agree it is better to have a "may trigger exception" flag
if for nothing else besides documentation.
> Given the default is READG | WRITEG, it would be difficult to do that
> unless we negate the flags. Actually NOWRITEG, NOREADG, NOSIDE might be
> a good way to go, and is more consistent that by default nothing should
> be implied.
Sure.
r~
[Qemu-devel] [PATCH 09/13] tcg: start with local temps in TEMP_VAL_MEM state, Aurelien Jarno, 2012/09/27
[Qemu-devel] [PATCH 10/13] tcg: don't explicitely save globals and temps, Aurelien Jarno, 2012/09/27
[Qemu-devel] [PATCH 07/13] tcg: rewrite tcg_reg_alloc_mov(), Aurelien Jarno, 2012/09/27
[Qemu-devel] [PATCH 05/13] tcg: rework liveness analysis, Aurelien Jarno, 2012/09/27