[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions |
Date: |
Tue, 04 Sep 2012 09:38:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
Il 04/09/2012 09:15, Wenchao Xia ha scritto:
>>>>> +/* this file contains helper function used internally. */
>>>>> +#define SECTOR_SIZE (512)
>>> Hard-coding this feels wrong, in this day and age of disks with 4096
>>> sectors. Why isn't this a per-image property?
>>
>> In this day and age of disks with 4096 sectors, Linux does not provide a
>> way to query the required alignment for O_DIRECT...
>>
>> Paolo
>>
> in block.h:
> #define BDRV_SECTOR_BITS 9
> #define BDRV_SECTOR_SIZE (1ULL << BDRV_SECTOR_BITS)
> #define BDRV_SECTOR_MASK ~(BDRV_SECTOR_SIZE - 1)
> it seems block size is always 512 in qemu block layer, so I can
> ignore the 4096 case, do you think so?
Yes. It is not well supported yet by QEMU, either.
Paolo
- Re: [Qemu-devel] [PATCH 3/6] libqblock error handling, (continued)
- [Qemu-devel] [PATCH 5/6] libqblock test example, Wenchao Xia, 2012/09/03
- [Qemu-devel] [PATCH 4/6] libqblock internal used functions, Wenchao Xia, 2012/09/03
- Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions, Paolo Bonzini, 2012/09/03
- Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions, Eric Blake, 2012/09/03
- Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions, Paolo Bonzini, 2012/09/03
- Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions, Wenchao Xia, 2012/09/04
- Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions, Eric Blake, 2012/09/04
- Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions, Paolo Bonzini, 2012/09/04
- Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions, Kevin Wolf, 2012/09/04
- Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions, Wenchao Xia, 2012/09/10
[Qemu-devel] [PATCH 6/6] libqblock building system, Wenchao Xia, 2012/09/03
[Qemu-devel] [PATCH 2/6] libqblock public type defines, Wenchao Xia, 2012/09/03