Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines

[Wenchao Xia]

于 2012-9-3 21:13, Paolo Bonzini 写道:
> Il 03/09/2012 11:18, Wenchao Xia ha scritto:
> > +union QBlockOption_fmt {
> > +    struct QBlockOption_fmt_cow       o_cow;
> > +    struct QBlockOption_fmt_qed       o_qed;
> > +    struct QBlockOption_fmt_qcow      o_qcow;
> > +    struct QBlockOption_fmt_qcow2     o_qcow2;
> > +    struct QBlockOption_fmt_raw       o_raw;
> > +    struct QBlockOption_fmt_rbd       o_rbd;
> > +    struct QBlockOption_fmt_sheepdog  o_sheepdog;
> > +    struct QBlockOption_fmt_vdi       o_vdi;
> > +    struct QBlockOption_fmt_vmdk      o_vmdk;
> > +    struct QBlockOption_fmt_vpc       o_vpc;
> > +};
> > +
> > +struct QBlockOptionFormat {
> > +    enum QBlockFormat fmt_type;
> > +    union QBlockOption_fmt fmt_op;
> > +    uint8_t reserved[512];
> > +};
>
> Padding must be in the union not the struct.  For the fourth time.
>
> Paolo
  I must have left it in some other patches, sorry about this key point
missing.



--
Best Regards

Wenchao Xia