[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/10] qom: export object_property_is_child, obj
From: |
liu ping fan |
Subject: |
Re: [Qemu-devel] [PATCH 03/10] qom: export object_property_is_child, object_property_is_link |
Date: |
Sat, 25 Aug 2012 15:43:06 +0800 |
On Fri, Aug 24, 2012 at 10:51 PM, Paolo Bonzini <address@hidden> wrote:
> Il 24/08/2012 11:49, Liu Ping Fan ha scritto:
>> From: Liu Ping Fan <address@hidden>
>>
>> qdev will use them to judge how to remove the bus and device's
>> reference. So export them in object.h
>
> This series doesn't use them.
>
Yeap, will fix it in V2.
Thanks,
pingfan
> Paolo
>
>> Signed-off-by: Liu Ping Fan <address@hidden>
>> ---
>> include/qemu/object.h | 3 +++
>> qom/object.c | 4 ++--
>> 2 files changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/qemu/object.h b/include/qemu/object.h
>> index cc75fee..7cc3ebb 100644
>> --- a/include/qemu/object.h
>> +++ b/include/qemu/object.h
>> @@ -431,6 +431,9 @@ struct InterfaceClass
>> #define INTERFACE_CHECK(interface, obj, name) \
>> ((interface *)object_dynamic_cast_assert(OBJECT((obj)), (name)))
>>
>> +inline bool object_property_is_child(ObjectProperty *prop);
>> +inline bool object_property_is_link(ObjectProperty *prop);
>> +
>> /**
>> * object_new:
>> * @typename: The name of the type of the object to instantiate.
>> diff --git a/qom/object.c b/qom/object.c
>> index 00f98d7..be460df 100644
>> --- a/qom/object.c
>> +++ b/qom/object.c
>> @@ -318,12 +318,12 @@ void object_initialize(void *data, const char
>> *typename)
>> object_initialize_with_type(data, type);
>> }
>>
>> -static inline bool object_property_is_child(ObjectProperty *prop)
>> +inline bool object_property_is_child(ObjectProperty *prop)
>> {
>> return strstart(prop->type, "child<", NULL);
>> }
>>
>> -static inline bool object_property_is_link(ObjectProperty *prop)
>> +inline bool object_property_is_link(ObjectProperty *prop)
>> {
>> return strstart(prop->type, "link<", NULL);
>> }
>>
>
- [Qemu-devel] [PATCH 0/10] rework on hot unplug, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 01/10] qom: add, remove of link property need to ref, unref its target, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 02/10] qdev: change iterator callback seq, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 03/10] qom: export object_property_is_child, object_property_is_link, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 04/10] qdev: introduce new interface to remove composite sub-tree, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 05/10] qdev: finalize of qbus, qdev will not the right place to free children, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 06/10] qom: expose object_property_del_child, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 07/10] unplug: using new intf qdev_delete_subtree in acpi_piix_eject_slot, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 09/10] mon: release dev's ref hold by qdev_get_peripheral, Liu Ping Fan, 2012/08/24