[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 09/10] mon: release dev's ref hold by qdev_get_perip
From: |
Liu Ping Fan |
Subject: |
[Qemu-devel] [PATCH 09/10] mon: release dev's ref hold by qdev_get_peripheral |
Date: |
Fri, 24 Aug 2012 17:49:22 +0800 |
From: Liu Ping Fan <address@hidden>
When add it at qdev_device_add(), so need to release it
at qmp_device_del().
Signed-off-by: Liu Ping Fan <address@hidden>
---
hw/qdev-monitor.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
index fdd9539..29ace17 100644
--- a/hw/qdev-monitor.c
+++ b/hw/qdev-monitor.c
@@ -599,6 +599,7 @@ int do_device_add(Monitor *mon, const QDict *qdict, QObject
**ret_data)
void qmp_device_del(const char *id, Error **errp)
{
DeviceState *dev;
+ int ret;
dev = qdev_find_recursive(sysbus_get_default(), id);
if (NULL == dev) {
@@ -606,7 +607,12 @@ void qmp_device_del(const char *id, Error **errp)
return;
}
- qdev_unplug_req(dev, errp);
+ ret = qdev_unplug_req(dev, errp);
+ if (ret == 0) {
+ /* to here, dev->id is not zero, so need to release */
+ object_property_del_child(qdev_get_peripheral(),
+ OBJECT(dev), NULL);
+ }
}
void qdev_machine_init(void)
--
1.7.4.4
- Re: [Qemu-devel] [PATCH 03/10] qom: export object_property_is_child, object_property_is_link, (continued)
- [Qemu-devel] [PATCH 04/10] qdev: introduce new interface to remove composite sub-tree, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 05/10] qdev: finalize of qbus, qdev will not the right place to free children, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 06/10] qom: expose object_property_del_child, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 07/10] unplug: using new intf qdev_delete_subtree in acpi_piix_eject_slot, Liu Ping Fan, 2012/08/24
- [Qemu-devel] [PATCH 09/10] mon: release dev's ref hold by qdev_get_peripheral,
Liu Ping Fan <=
- [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem, Liu Ping Fan, 2012/08/24
- Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem, Paolo Bonzini, 2012/08/24
- Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem, liu ping fan, 2012/08/25
- Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem, Paolo Bonzini, 2012/08/27
- Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem, Jan Kiszka, 2012/08/27
- Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem, liu ping fan, 2012/08/27
- Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem, Jan Kiszka, 2012/08/27
- Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem, Avi Kivity, 2012/08/27
- Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem, Jan Kiszka, 2012/08/27
- Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem, Avi Kivity, 2012/08/27