Re: [Qemu-devel] [PATCH RFC for-1.2] arm: Move some ARM devices into libhw

[Peter Maydell]

On 2 August 2012 02:16, Andreas Färber <address@hidden> wrote:
> Signed-off-by: Andreas Färber <address@hidden>
> ---
>  Hello Peter, here's my current draft for subjecting more arm devices to the
>  stricter device checks in libhwX. Please review desired granularity (here:
>  fine-grained) and naming (e.g., PL310 vs. l2x0).
>  Since this is preparing for a future armeb-softmmu, Anthony's CONFIG_ARCH_ARM
>  is not going to help here (we would want to turn off many devices for armeb).
>  The SoCs with references to CPUs in their header are untouched, i.MX31 was
>  not yet reviewed for movability.

So what's our long term vision here? Every device has a CONFIG_FOO that
gets turned on in some default-configs/ file?

What are the 'stricter checks' you mention?

> +hw-obj-$(CONFIG_PL310) += arm_l2x0.o

Maybe we should have named the source file pl310.c...

> +hw-obj-$(CONFIG_STELLARIS_ENET) += stellaris_enet.o

Why just this stellaris device and not the others?
> -obj-y += pl041.o lm4549.o
> +obj-y += lm4549.o

If we're moving the pl041 we should move its accompanying codec
(the lm4549) too, especially since the pl041 is definitely ARM
only but the lm4549 could be used on other platforms in theory.

-- PMM