|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 13/34] hmp: hmp_change(): don't rely on QERR_DEVICE_ENCRYPTED |
Date: | Thu, 02 Aug 2012 15:46:48 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
Il 02/08/2012 15:27, Markus Armbruster ha scritto: >> > + bdev_list = qmp_query_block(NULL); >> > + for (bdev = bdev_list; bdev; bdev = bdev->next) { >> > + if (!strcmp(bdev->value->device, device) && >> > + blockinfo_is_encrypted(bdev->value) && >> > + !blockinfo_key_is_set(bdev->value)) { >> > + hmp_change_ask_user_key(mon, bdev->value); >> > + break; >> > + } >> > + } Is this anything that an external application can reproduce? Perhaps we need to keep QERR_DEVICE_ENCRYPTED even if libvirt does not use it, or at least provide an alternative mechanism (e.g. an event) to realize its effect. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |