Re: [Qemu-devel] [PATCH v2 11/11] xilinx_axidma: changed device name

[Andreas Färber]

Am 16.06.2012 03:11, schrieb Edgar E. Iglesias:
> On Fri, Jun 15, 2012 at 01:30:17PM +0200, Andreas Färber wrote:
>> Am 13.06.2012 06:46, schrieb Peter A. G. Crosthwaite:
>>> Changed device name to xlnx,axi-dma. This is the exact name of the device 
>>> in the
>>> Xilinx EDK development tools.
>>>
>>> Signed-off-by: Peter A. G. Crosthwaite <address@hidden>
>>
>> Same here. Please review more carefully.

[referring to: Commit message doesn't match the change. Which one is right?]

> Code is an approximation of the real name. Commas are not ok
> in QEMU, so dot will do.
> If you wan't quality reviews, pay somebody to verify comments vs code.
> 
> I'll review best effort when time permits until somone pays me for
> doing better. Dont matter what you or anyone says.

If you want a pay rise, talk to John. But don't take the QEMU community
hostage.

Maybe I was a bit brief, not much time for upstream myself lately: I'm
not bitching about some minor English-language grammar typo that slipped
you by, I am complaining about you committing a patch that claims to do
one thing and in fact does another for the sole thing it is doing.

It would have taken you all of five seconds to fix that yourself - or
ask your colleague to fix it if many you're even in the same office at
Petalogix. I've been student, hobbyist and now professional developer
and my (lack of) payment has never been a criteria for accepting patches
here on qemu-devel. Especially from you as a committer I expect to give
a good role model to Joe developer. Usually you and Peter C. do pretty
well and a simple "Oops, I'll try to catch it next time" plus a review
of which version you guys really intended was all I wanted from you. Is
that really too much to ask?

Listening to what people say to your contributions is part of Open
Source development, I'm pretty sure that's not what you meant to oppose
with the above but it can be read in such a way.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg