Re: [Qemu-devel] [PATCH v2 11/11] xilinx_axidma: changed device name

[Alexander Graf]

On 16.06.2012, at 03:11, Edgar E. Iglesias wrote:

> On Fri, Jun 15, 2012 at 01:30:17PM +0200, Andreas Färber wrote:
>> Am 13.06.2012 06:46, schrieb Peter A. G. Crosthwaite:
>>> Changed device name to xlnx,axi-dma. This is the exact name of the device 
>>> in the
>>> Xilinx EDK development tools.
>>> 
>>> Signed-off-by: Peter A. G. Crosthwaite <address@hidden>
>> 
>> Same here. Please review more carefully.
> 
> Code is an approximation of the real name. Commas are not ok
> in QEMU, so dot will do.
> If you wan't quality reviews, pay somebody to verify comments vs code.
> 
> I'll review best effort when time permits until somone pays me for
> doing better. Dont matter what you or anyone says.

Yeah, that's perfectly fine and I don't think anyone would reasonably expect 
any different from you :). Overall, you have been an awesome maintainer for 
your components, so thanks a lot for your work :). I'm pretty sure Andreas 
didn't mean the above the way you perceived it :).

So let me take the chance and rephrase his comment: Why did commas in names 
work before, but now don't? Or put differently: Was this change on purpose?

> 
> Cheers
> 
> 
> 
>> 
>> /-F
>> 
>>> ---
>>> hw/xilinx.h        |    2 +-
>>> hw/xilinx_axidma.c |    4 ++--
>>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>> 
>>> diff --git a/hw/xilinx.h b/hw/xilinx.h
>>> index 8f915b4..7df21eb 100644
>>> --- a/hw/xilinx.h
>>> +++ b/hw/xilinx.h
>>> @@ -75,7 +75,7 @@ xilinx_axiethernetdma_create(void *dmach,
>>> {
>>>     DeviceState *dev = NULL;
>>> 
>>> -    dev = qdev_create(NULL, "xilinx,axidma");
>>> +    dev = qdev_create(NULL, "xlnx.axi-dma");

comma -> dot

>>>     qdev_prop_set_uint32(dev, "freqhz", freqhz);
>>>     qdev_prop_set_ptr(dev, "dmach", dmach);
>>>     qdev_init_nofail(dev);
>>> diff --git a/hw/xilinx_axidma.c b/hw/xilinx_axidma.c
>>> index 59373b5..f4bec37 100644
>>> --- a/hw/xilinx_axidma.c
>>> +++ b/hw/xilinx_axidma.c
>>> @@ -473,7 +473,7 @@ static int xilinx_axidma_init(SysBusDevice *dev)
>>>     xlx_dma_connect_dma(s->dmach, s, axidma_push);
>>> 
>>>     memory_region_init_io(&s->iomem, &axidma_ops, s,
>>> -                          "axidma", R_MAX * 4 * 2);
>>> +                          "xlnx.axi-dma", R_MAX * 4 * 2);
>>>     sysbus_init_mmio(dev, &s->iomem);
>>> 
>>>     for (i = 0; i < 2; i++) {
>>> @@ -502,7 +502,7 @@ static void axidma_class_init(ObjectClass *klass, void 
>>> *data)
>>> }
>>> 
>>> static TypeInfo axidma_info = {
>>> -    .name          = "xilinx,axidma",
>>> +    .name          = "xlnx.axi-dma",

comma -> dot


Alex