Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor

[Andreas Färber]

Am 05.06.2012 12:00, schrieb Peter Maydell:
> On 5 June 2012 02:00, Michael Roth <address@hidden> wrote:
>> +The first step is to move your device struct definition to a header file.  
>> This
>> +header file should only contain the struct definition and any preprocessor
>> +declarations you need to define the structure.  This header file will act as
>> +the source for the QC IDL compiler.
> 
> I don't think this is a fantastic idea -- the device struct should be
> private to the device, and having it in a standalone header file is
> asking for users of the device to illicitly include it and access
> internals that they shouldn't.

But that is exactly where realize is headed. PCIBus, a9mp_priv etc.
structs will need to be made public so that they can be embedded.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg