qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor
Date: Wed, 06 Jun 2012 07:12:08 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1

Il 06/06/2012 01:40, Anthony Liguori ha scritto:
>>
>>> The only way I can think of getting around this is to do nasty things
>>> like adding an
>>>
>>> #include "qapi-generated/mc146818rtc-qapi-visit.c";
>>>
>>> in hw/mc146818rtc.c.
>>
>> It doesn't look that ugly, though perhaps I'm biased because that's
>> again exactly what GCC does.
> 
> A cleaner way to do this this to have mc146818rtc-qapi-visit.c have:
> 
> #include "mc146818rtc.c"
> 
> As the first line of the file.  Then don't build mc146818rtc.c directly
> and instead only build the qapi-visit.o variant.
> 
> This could all be done through make magic too.

Sounds like we have very different definitions of clean. :)

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]