[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/6] block: change block-job-set-speed argume
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/6] block: change block-job-set-speed argument from 'value' to 'speed' |
Date: |
Tue, 24 Apr 2012 16:02:02 -0300 |
On Tue, 24 Apr 2012 09:03:06 -0600
Eric Blake <address@hidden> wrote:
> > +++ b/hmp-commands.hx
> > @@ -85,8 +85,8 @@ ETEXI
> >
> > {
> > .name = "block_job_set_speed",
> > - .args_type = "device:B,value:o",
> > - .params = "device value",
> > + .args_type = "device:B,speed:o",
> > + .params = "device speed",
>
> For that matter, can the :o type _ever_ usefully allow negative values,
> or is it always an unsigned calculation?
It does allow for negative values. As an example, migrate_set_speed rounds
the value to zero if it's negative.
- [Qemu-devel] [PATCH v2 0/6] block: add optional 'speed' parameter to block-stream, Stefan Hajnoczi, 2012/04/24
- [Qemu-devel] [PATCH v2 4/6] block: add 'speed' optional parameter to block-stream, Stefan Hajnoczi, 2012/04/24
- [Qemu-devel] [PATCH v2 3/6] block: change block-job-set-speed argument from 'value' to 'speed', Stefan Hajnoczi, 2012/04/24
- [Qemu-devel] [PATCH v2 2/6] block: use Error mechanism instead of -errno for block_job_set_speed(), Stefan Hajnoczi, 2012/04/24
- [Qemu-devel] [PATCH v2 1/6] block: use Error mechanism instead of -errno for block_job_create(), Stefan Hajnoczi, 2012/04/24
- [Qemu-devel] [PATCH v2 5/6] qemu-iotests: add block-stream with invalid speed value test, Stefan Hajnoczi, 2012/04/24
- [Qemu-devel] [PATCH v2 6/6] qemu-iotests: fix missing 'result' variable assignment in 030, Stefan Hajnoczi, 2012/04/24
- Re: [Qemu-devel] [PATCH v2 0/6] block: add optional 'speed' parameter to block-stream, Luiz Capitulino, 2012/04/24