|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH v2 1/6] block: use Error mechanism instead of -errno for block_job_create() |
Date: | Tue, 24 Apr 2012 08:44:14 -0600 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
On 04/24/2012 07:53 AM, Stefan Hajnoczi wrote: > The block job API uses -errno return values internally and we convert > these to Error in the QMP functions. This is ugly because the Error > should be created at the point where we still have all the relevant > information. More importantly, it is hard to add new error cases to > this case since we quickly run out of -errno values without losing > information. > > Go ahead an use Error directly and don't convert later. s/an /and / -- Eric Blake address@hidden +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] | Current Thread | [Next in Thread] |