[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/24] qom: make Object a type
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/24] qom: make Object a type |
Date: |
Thu, 12 Apr 2012 18:26:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120312 Thunderbird/11.0 |
Am 11.04.2012 23:30, schrieb Paolo Bonzini:
> Right now the base Object class has a special NULL type. Change this so
> that we will be able to add class_init and class_base_init callbacks.
> To do this, remove some special casing of ObjectClass that is not really
> necessary.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
I had also pointed out that no longer handling .parent = NULL as
TYPE_OBJECT can have unwanted effects of not deriving some objects from
TYPE_OBJECT. I see no statement that the code was reviewed for TypeInfos
that don't set .parent (or set it to NULL). Nor do I see the suggested
check against whitelisted base classes "object" and "interface" to
detect such uses at startup. Do you want a patch for that, forgot or
decided against?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
[Qemu-devel] [PATCH v2 08/24] qdev: move bus properties to a separate global, Paolo Bonzini, 2012/04/11
[Qemu-devel] [PATCH v2 07/24] qdev: use object_property_print in info qtree, Paolo Bonzini, 2012/04/11