[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 07/24] qdev: use object_property_print in info qt
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH v2 07/24] qdev: use object_property_print in info qtree |
Date: |
Wed, 11 Apr 2012 23:30:25 +0200 |
Otherwise, non-string properties without a legacy counterpart are missed.
Also fix error propagation in object_property_print itself.
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/qdev-monitor.c | 2 +-
qom/object.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
index 0acfc82..07ac525 100644
--- a/hw/qdev-monitor.c
+++ b/hw/qdev-monitor.c
@@ -492,7 +492,7 @@ static void qdev_print_props(Monitor *mon, DeviceState
*dev, Property *props,
if (object_property_get_type(OBJECT(dev), legacy_name, NULL)) {
value = object_property_get_str(OBJECT(dev), legacy_name, &err);
} else {
- value = object_property_get_str(OBJECT(dev), props->name, &err);
+ value = object_property_print(OBJECT(dev), props->name, &err);
}
g_free(legacy_name);
diff --git a/qom/object.c b/qom/object.c
index f3ffaa6..ff36946 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -850,7 +850,7 @@ char *object_property_print(Object *obj, const char *name,
char *string;
mo = string_output_visitor_new();
- object_property_get(obj, string_output_get_visitor(mo), name, NULL);
+ object_property_get(obj, string_output_get_visitor(mo), name, errp);
string = string_output_get_string(mo);
string_output_visitor_cleanup(mo);
return string;
--
1.7.9.3
[Qemu-devel] [PATCH v2 05/24] qdev: push "type" property up to Object, Paolo Bonzini, 2012/04/11
[Qemu-devel] [PATCH v2 06/24] qdev: fix -device foo,?, Paolo Bonzini, 2012/04/11
[Qemu-devel] [PATCH v2 08/24] qdev: move bus properties to a separate global, Paolo Bonzini, 2012/04/11
[Qemu-devel] [PATCH v2 07/24] qdev: use object_property_print in info qtree,
Paolo Bonzini <=
[Qemu-devel] [PATCH v2 09/24] qdev: do not propagate properties to subclasses, Paolo Bonzini, 2012/04/11
[Qemu-devel] [PATCH v2 11/24] qdev: clean up global properties, Paolo Bonzini, 2012/04/11
[Qemu-devel] [PATCH v2 10/24] qdev: move bus properties to abstract superclasses, Paolo Bonzini, 2012/04/11
[Qemu-devel] [PATCH v2 12/24] qdev: remove qdev_prop_set_defaults, Paolo Bonzini, 2012/04/11
[Qemu-devel] [PATCH v2 13/24] qapi: add Visitor interfaces for uint*_t and int*_t, Paolo Bonzini, 2012/04/11
[Qemu-devel] [PATCH v2 14/24] qdev: use int32_t container for devfn property, Paolo Bonzini, 2012/04/11
[Qemu-devel] [PATCH v2 15/24] qdev: switch property accessors to fixed-width visitor interfaces, Paolo Bonzini, 2012/04/11
[Qemu-devel] [PATCH v2 17/24] qdev: remove qdev_prop_exists, Paolo Bonzini, 2012/04/11
[Qemu-devel] [PATCH v2 16/24] qdev: remove PropertyInfo range checking, Paolo Bonzini, 2012/04/11