[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris |
Date: |
Tue, 27 Mar 2012 17:52:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
Il 27/03/2012 17:08, Jan Kiszka ha scritto:
>>> +#if defined(__sun__)
>>> + if (timer_create(CLOCK_HIGHRES, &ev, &host_timer)) {
>>> +#else
>>> if (timer_create(CLOCK_REALTIME, &ev, &host_timer)) {
>>> +#endif
>>
>> This should be #ifdef CLOCK_HIGHRES.
>
> Are we sure about this is and will remain equivalent and correct?
>
> Also, I found some man page that says CLOCK_HIGHRES is non-adjustable
> while CLOCK_REALTIME is. That should make a difference in QEMU.
Right, that's why I CCed you but then I forgot to ask the question.
Does QEMU rely on CLOCK_REALTIME when "-rtc clock=host" is in use? A
monotonic clock would work better when CLOCK_REALTIME jumps backwards
(DST->solar). If the jump goes unnoticed, the alarm timer would have no
timeout for an hour or so.
Of course the opposite is true when going from solar time to DST; you
move the realtime clock one hour forward and, with CLOCK_MONOTONIC, a
host_clock timer to trigger an hour too late.
Paolo
- Re: [Qemu-devel] [PATCH 2/4] Enable sigbus_reraise for Solaris, (continued)
Re: [Qemu-devel] [PATCH 2/4] Enable sigbus_reraise for Solaris, Jan Kiszka, 2012/03/27
[Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris, Lee Essen, 2012/03/24
[Qemu-devel] [PATCH 4/4] qga/channel-posix: provide Solaris alternative to O_ASYNC, Lee Essen, 2012/03/24
Re: [Qemu-devel] [PATCH 1/4] Add socket/xnet libs to configure for Solaris, Stefan Hajnoczi, 2012/03/27