[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] Enable sigbus_reraise for Solaris
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] Enable sigbus_reraise for Solaris |
Date: |
Tue, 27 Mar 2012 15:49:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-03-24 17:26, Lee Essen wrote:
> sigbus_reraise is used by the kvm_wait_io_event function and is
> needed on both Linux and Solaris. This patch adds CONFIG_SOLARIS
> to the current CONFIG_LINUX only ifdef.
>
> Signed-off-by: Lee Essen <address@hidden>
> ---
> cpus.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/cpus.c b/cpus.c
> index 25ba621..6550f22 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -455,7 +455,7 @@ static void cpu_signal(int sig)
> exit_request = 1;
> }
>
> -#ifdef CONFIG_LINUX
> +#if defined(CONFIG_LINUX) || defined(CONFIG_SOLARIS)
> static void sigbus_reraise(void)
> {
> sigset_t set;
> @@ -491,7 +491,9 @@ static void qemu_init_sigbus(void)
> action.sa_sigaction = (void (*)(int, siginfo_t*, void*))sigbus_handler;
> sigaction(SIGBUS, &action, NULL);
>
> +#if defined(CONFIG_LINUX)
> prctl(PR_MCE_KILL, PR_MCE_KILL_SET, PR_MCE_KILL_EARLY, 0, 0);
> +#endif
BTW, this looks suspicious. Are you sure Solaris delivers a compatible
SIGBUS with all the information KVM needs to translate it to a MCE? That
is not a KVM subsystem feature, it's a kernel feature that Solaris would
either have to provide in the same way as Linux, or you need some glue
code to translate the differences.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
[Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris, Lee Essen, 2012/03/24
[Qemu-devel] [PATCH 4/4] qga/channel-posix: provide Solaris alternative to O_ASYNC, Lee Essen, 2012/03/24
Re: [Qemu-devel] [PATCH 1/4] Add socket/xnet libs to configure for Solaris, Stefan Hajnoczi, 2012/03/27