Re: [Qemu-devel] [patch V4 1/4] i.MX UART support

[Peter Maydell]

On 9 March 2012 03:27,  <address@hidden> wrote:
> +typedef struct {
> +    SysBusDevice busdev;
> +    MemoryRegion iomem;
> +    int32_t readbuff;
> +
> +    uint32_t usr1;
> +    uint32_t usr2;
> +    uint32_t ucr1;
> +    uint32_t ucr2;
> +    uint32_t uts1;
> +
> +    /*
> +     * The registers below are implemented just so that the
> +     * guest OS sees what it has written
> +     */
> +    uint32_t onems;
> +    uint32_t ufcr;
> +    uint32_t ubmr;
> +    uint32_t ubrc;
> +    uint32_t ucr3;
> +
> +    qemu_irq irq;
> +    CharDriverState *chr;
> +} imx_state;

CODING_STYLE says this should be CamelCase. Also shouldn't
the type name have the word 'serial' or 'uart' in it somewhere?

Otherwise looks good.

-- PMM