[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/3] kvmclock: Always register type
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/3] kvmclock: Always register type |
Date: |
Mon, 05 Mar 2012 11:23:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
On 03/04/2012 10:32 PM, Andreas Färber wrote:
> Currently, the "kvmclock" type is only registered when kvm_enabled().
>
> This breaks when moving type registration to before command line
> parsing (so that QOM types can be used for CPU and machine).
>
> Since the QOM classes are lazy-initialized anyway and kvmclock_create()
> has another kvm_enabled() check, simply drop the KVM check in
> kvmclock_register_types().
>
> kvm-i8259, kvm-apic and kvm-ioapic do not suffer from such a check.
Patch looks good.
--
error compiling committee.c: too many arguments to function