[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/3] kvmclock: Always register type
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/3] kvmclock: Always register type |
Date: |
Mon, 12 Mar 2012 12:36:40 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
On 03/10/2012 03:35 AM, Andreas Färber wrote:
> Am 05.03.2012 10:23, schrieb Avi Kivity:
> > On 03/04/2012 10:32 PM, Andreas Färber wrote:
> >> Currently, the "kvmclock" type is only registered when kvm_enabled().
> >>
> >> This breaks when moving type registration to before command line
> >> parsing (so that QOM types can be used for CPU and machine).
> >>
> >> Since the QOM classes are lazy-initialized anyway and kvmclock_create()
> >> has another kvm_enabled() check, simply drop the KVM check in
> >> kvmclock_register_types().
> >>
> >> kvm-i8259, kvm-apic and kvm-ioapic do not suffer from such a check.
> >
> > Patch looks good.
>
> Ping for series.
>
> Avi, do you want to sign this patch off through uq/master? Or should I
> make the above a Reviewed-by (and remove the Cc:) within this series?
>
Reviewed-by: please.
--
error compiling committee.c: too many arguments to function
[Qemu-devel] [PATCH v4 01/44] PPC: 405: Use proper CPU reset, Andreas Färber, 2012/03/09
[Qemu-devel] [PATCH RFC v4 15/44] target-cris: Don't overuse CPUState, Andreas Färber, 2012/03/09