[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH][RFC] arm: add secondary cpu book callbacks to a
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH][RFC] arm: add secondary cpu book callbacks to arm_boot.c |
Date: |
Wed, 18 Jan 2012 16:23:13 +0000 |
On 18 January 2012 15:50, Mark Langsdorf <address@hidden> wrote:
> Create two functions, write_secondary_boot() and secondary_cpu_reset_hook(),
> to allow platforms more control of how secondary CPUs are brought up. The
> new functions default to NULL and aren't called unless they are populated
> so there are no changes to existing platform models.
>
> Signed-off-by: Mark Langsdorf <address@hidden>
> ---
> I'll add this to the Highbank patch series but I wanted to throw it out
> now to make sure the general structure was good.
Looks OK. I'm tempted to suggest that we should pull the default
code out into separate functions and then at the top of arm_load_kernel()
do
if (!info->write_secondary_boot) {
info->write_secondary_boot = default_write_secondary_boot;
}
if (!info->secondary_cpu_reset_hook) {
info->secondary_cpu_reset_hook = default_secondary_cpu_reset_hook;
}
Then we can put all the secondary-cpu-related code that is in arm_boot.c
in one place in the file.
Probably also nice to add a comment about which fields in arm_boot_info
are only required if you're using the default write_secondary_boot.
-- PMM
- Re: [Qemu-devel] [PATCH v9 0/6] arm: add support for Calxeda Highbank SoC, (continued)
- [Qemu-devel] [PATCH v10 0/5] arm: add support for Calxeda Highbank, Mark Langsdorf, 2012/01/17
- [Qemu-devel] [PATCH v10 1/5] Add xgmac ethernet model, Mark Langsdorf, 2012/01/17
- [Qemu-devel] [PATCH v10 4/5] arm: SoC model for Calxeda Highbank, Mark Langsdorf, 2012/01/17
- Re: [Qemu-devel] [PATCH v10 4/5] arm: SoC model for Calxeda Highbank, Peter Maydell, 2012/01/17
- Re: [Qemu-devel] [PATCH v10 4/5] arm: SoC model for Calxeda Highbank, Mark Langsdorf, 2012/01/18
- Re: [Qemu-devel] [PATCH v10 4/5] arm: SoC model for Calxeda Highbank, Peter Maydell, 2012/01/18
- Re: [Qemu-devel] [PATCH v10 4/5] arm: SoC model for Calxeda Highbank, Mark Langsdorf, 2012/01/18
- Re: [Qemu-devel] [PATCH v10 4/5] arm: SoC model for Calxeda Highbank, Peter Maydell, 2012/01/18
- [Qemu-devel] [PATCH][RFC] arm: add secondary cpu book callbacks to arm_boot.c, Mark Langsdorf, 2012/01/18
- Re: [Qemu-devel] [PATCH][RFC] arm: add secondary cpu book callbacks to arm_boot.c,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH v10 4/5] arm: SoC model for Calxeda Highbank, Mark Langsdorf, 2012/01/18
- Re: [Qemu-devel] [PATCH v10 4/5] arm: SoC model for Calxeda Highbank, Peter Maydell, 2012/01/18
- Re: [Qemu-devel] [PATCH v10 4/5] arm: SoC model for Calxeda Highbank, Peter Maydell, 2012/01/18
- Re: [Qemu-devel] [PATCH v10 4/5] arm: SoC model for Calxeda Highbank, Mark Langsdorf, 2012/01/18
- [Qemu-devel] [PATCH v10 3/5] ahci: add support for non-PCI based controllers, Mark Langsdorf, 2012/01/17
- [Qemu-devel] [PATCH v10 2/5] arm: make the number of GIC interrupts configurable, Mark Langsdorf, 2012/01/17
- [Qemu-devel] [PATCH v10 5/5] arm: Remove incorrect comment in arm_timer, Mark Langsdorf, 2012/01/17
[Qemu-devel] [PATCH v11 0/5] arm: add support for Calxeda Highbank, Mark Langsdorf, 2012/01/19