[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V2 2/3] hw/sd.c: add SD card save/load support

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH V2 2/3] hw/sd.c: add SD card save/load support
Date: Wed, 28 Dec 2011 14:41:04 +0000

On 28 December 2011 14:02, Mitsyanko Igor <address@hidden> wrote:
> On 12/28/2011 05:26 PM, Peter Maydell wrote:
>> Also, why should we care particularly about the order of
>> fields in SDState? There will be at most a handful of copies
>> of this struct in qemu, costing a handful of bytes in extra
>> padding. ("ensure proper data alignment" is wrong -- the compiler
>> does this for us.) If you feel you must rearrange things, again,
>> please put it in a separate patch so it's easier to read.
> Why not, it wouldn't hurt anyone.

Basically I think this is pointless microoptimisation. If you
haven't measured something and determined that this is a useful
change because it makes things faster or usefully decreases
memory use by some non-trivial amount, then this kind of change
is a poor use of your time and also mine (as reviewer) and of
whoever eventually commits the patch to git.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]