Re: [Qemu-devel] [PATCH 3/3] hw/: Introduce spec. ver. 2.00 compliant SD host controller

[malc]

On Mon, 26 Dec 2011, Mitsyanko Igor wrote:

> This patch adds implementation of "SD specification version 2.00" compliant
> SD host controller. Also it provides interface to implement SoC-specific
> controllers on top of this specification-compliant one.
> 
[..snip..]

> +
> +void sdhcv2_reset(SDHCv2State *s)
> +{
> +    unsigned long begin = (unsigned long)s + offsetof(SDHCv2State, 
> sdmasysad);

This is wrong, 

uintptr_t begin = (uintptr_t) &s->sdmasysad;

Caveat emptor: i haven't tried to understand what the code tries to
accomplish, so maybe there's a way that doesn't involve even the above.

[..snip..]

-- 
mailto:address@hidden