[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] [v2] arm gic saving/loading fix
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] [v2] arm gic saving/loading fix |
Date: |
Wed, 19 Oct 2011 19:21:09 +0100 |
On 19 October 2011 15:10, Dmitry Koshelev <address@hidden> wrote:
> irq_target field saving/loading is in the wrong loop
> version bump
>
> Signed-off-by: Dmitry Koshelev <address@hidden>
> ---
> hw/arm_gic.c | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> @@ -744,5 +744,5 @@ static void gic_init(gic_state *s)
> s->iomemtype = cpu_register_io_memory(gic_dist_readfn,
> gic_dist_writefn, s);
> gic_reset(s);
> - register_savevm(NULL, "arm_gic", -1, 1, gic_save, gic_load, s);
> + register_savevm(NULL, "arm_gic", -1, 2, gic_save, gic_load, s);
> }
>
This doesn't apply against master -- can you rebase, please?
Since you need to resend anyway, convention for git commit messages
is to put the filename in the summary line, something like
hw/arm_gic.c: Fix save/load of irq_target array
Also, if at all possible, can you send via a mailer which doesn't
wrap long lines? Otherwise I have to fix them at this end which
is very tedious...
thanks
-- PMM