qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] libcacard: Fix wrong assertion (reported by cppchec


From: Stefan Weil
Subject: [Qemu-devel] [PATCH] libcacard: Fix wrong assertion (reported by cppcheck)
Date: Wed, 19 Oct 2011 21:03:22 +0200

assert("...") will never do anything. This assertion handles a case
which should never occur, so it must be assert(!"...").

Cc: Alon Levy <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
---
 libcacard/card_7816.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libcacard/card_7816.c b/libcacard/card_7816.c
index 9fd59d4..6fe27d5 100644
--- a/libcacard/card_7816.c
+++ b/libcacard/card_7816.c
@@ -754,7 +754,7 @@ vcard_process_apdu(VCard *card, VCardAPDU *apdu, 
VCardResponse **response)
         return vcard7816_vm_process_apdu(card, apdu, response);
     case VCARD_DIRECT:
         /* if we are type direct, then the applet should handle everything */
-        assert("VCARD_DIRECT: applet failure");
+        assert(!"VCARD_DIRECT: applet failure");
         break;
     }
     *response =
-- 
1.7.2.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]